changed the name of all variables with min/max name #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parth Lawania <[email protected]>
|
Thanks! Could you also remove these lines and make sure our linter is happy with your changes? Lines 69 to 70 in ffc4cc6 |
Removed the conditions. Please review the PR again. |
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
* changed the name of all variables with min/max name Signed-off-by: Parth Lawania <[email protected]> * removed predeclared ignore condition for min and max identifiers Signed-off-by: Parth Lawania <[email protected]> --------- Signed-off-by: Parth Lawania <[email protected]> Co-authored-by: Parth Lawania <[email protected]> Signed-off-by: Eugene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min/maxsince go now includesminandmaxin the list of predeclared identifiers